Small scan-handler fixes #16721
Merged
Small scan-handler fixes #16721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't yet expose the metadata in pylibcudf, so we can't handle this correctly.
wence-
added
improvement
wence-
requested review from
bdice and
Matt711
and removed request for
a team
github-actions
bot
added
Python
bdice
approved these changes
Sep 3, 2024
| @@ -222,6 +222,8 @@ def __post_init__(self) -> None: | |||
| raise NotImplementedError( | |||
| "Read from cloud storage" | |||
| ) # pragma: no cover; no test yet | |||
| if any(p.startswith("https://") for p in self.paths): | |||
There was a problem hiding this comment.
What about http:// or other protocols?
There was a problem hiding this comment.
The only way this occurs is because the user wrote scan_foo("hf://some_path/") and it is expanded before we see it into https://huggingface..../some_path.
So I could tighten up to match the full path.
There was a problem hiding this comment.
I had a broader brush to catch other URL-like things too.
There was a problem hiding this comment.
This is probably fine. If no https:// URLs are supported then let’s not make it specific to HuggingFace.
vyasr
approved these changes
Sep 3, 2024
|
Yes, I’m happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reject two more edge cases that we do not support.
We could easily support the case where the parquet read just needs to read the metadata, but it is low priority, so have not done so here.
Checklist